Improve parallelism of Lock operations#1480
Improve parallelism of Lock operations#1480VictorCavichioli wants to merge 6 commits intoEricsson:agent/masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## agent/master #1480 +/- ##
===============================================
Coverage ? 54.33%
Complexity ? 1408
===============================================
Files ? 194
Lines ? 8736
Branches ? 845
===============================================
Hits ? 4747
Misses ? 3717
Partials ? 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VictorCavichioli
force-pushed
the
fix/jobs-late
branch
from
c7b5e6f to
d809639
Compare
VictorCavichioli
force-pushed
the
fix/jobs-late
branch
from
d809639 to
6ef9bb8
Compare
| private void throwCachedLockException(final LockException e) throws LockException | ||
| { | ||
| LOG.debug("Encountered cached locking failure, throwing exception", e); | ||
| LOG.info("[DIAG] Lock blocked by cached failure: {}", e.getMessage()); |
There was a problem hiding this comment.
What is the idea with these [DIAG] log entries? Are they temporary for this PR? I mean, going from DEBUG to INFO and attaching a DIAG tag...
| private void throwCachedLockException(final LockException e) throws LockException | ||
| { | ||
| LOG.debug("Encountered cached locking failure, throwing exception", e); | ||
| LOG.info("[DIAG] Lock blocked by cached failure: {}", e.getMessage()); |
There was a problem hiding this comment.
Please, don't do e.getMessage(). It will only print the message, it dosen't tell you what the exception was. Remove to {} and do just e the way it was before, that will give you the expetion, the message and the stack trace.
VictorCavichioli
force-pushed
the
fix/jobs-late
branch
from
5c40b85 to
d23821f
Compare
4 participants
No description provided.